Skip to content

Add an integration test to verify DirectIO is used for at least one case #128370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Add an integration test to verify DirectIO is used for at least one case #128370

merged 1 commit into from
May 23, 2025

Conversation

@thecoop
Copy link
Member

@thecoop thecoop commented May 23, 2025

This test requires compound file to be turned off (as discussed previously)

@thecoop thecoop requested a review from ChrisHegarty May 23, 2025 13:23
@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Search Relevance/Vectors Vector search labels May 23, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 23, 2025

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label May 23, 2025
ChrisHegarty
ChrisHegarty approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop merged commit 09a6f9c into elastic:lucene_snapshot May 23, 2025
13 of 17 checks passed
@thecoop thecoop deleted the directio-it branch May 23, 2025 16:26
This was referenced May 26, 2025
Merged
Merged
Merged
ChrisHegarty added a commit that referenced this pull request May 28, 2025
@ChrisHegarty
[9.x] Add an integration test to verify DirectIO is used for BBQ resc…
4a831d0 
…oring (#128465)

Port DirectIOIT from lucene_snapshot to main.

relates #128370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees

No one assigned

Labels

:Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thecoop @elasticsearchmachine @ChrisHegarty